Skip to content

data/azure/grub9.6+: update expected grub config#457

Merged
alexxa merged 1 commit intomainfrom
rhel/azure/grub/serial-io
Sep 9, 2025
Merged

data/azure/grub9.6+: update expected grub config#457
alexxa merged 1 commit intomainfrom
rhel/azure/grub/serial-io

Conversation

@achilleas-k
Copy link
Member

@achilleas-k achilleas-k commented Sep 8, 2025 •
edited by sourcery-ai bot
Loading

Update the expected grub config to match the latest changes.

osbuild/images#1814

RHEL 9: RHEL-95423
RHEL 10: RHEL-95418

Summary by Sourcery

Tests:

  • Refresh the data/azure/grub_rhel9.6+ test fixture to align with updated grub config lines for RHEL 9 and 10

@sourcery-ai
Copy link

sourcery-ai bot commented Sep 8, 2025 •
edited
Loading

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR updates the Azure‐specific GRUB golden configuration for RHEL 9.6+ by regenerating the expected config to align with the latest osbuild/images changes and the corresponding RHEL bug fixes.

File-Level Changes

Change Details Files
Regenerate GRUB expected config to reflect new defaults
  • Applied changes from osbuild/images PR 1814
  • Updated kernel command line flags per RHEL-95423 and RHEL-95418
  • Adjusted default timeout and menu entry ordering
 data/azure/grub_rhel9.6+
Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

sourcery-ai[bot]
sourcery-ai bot reviewed Sep 8, 2025
View reviewed changes
Copy link

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@achilleas-k achilleas-k requested a review from alexxa September 8, 2025 17:24
@achilleas-k achilleas-k mentioned this pull request Sep 8, 2025
Merged
@achilleas-k
Copy link
Member Author

achilleas-k commented Sep 9, 2025

Does the CI here run the CIV against osbuild-composer's main branch? I have changes in a PR that require updating the CIV test, but updating the CIV test will require the changes to be merged. What's the process for making changes to image properties that are tested by CIV?

@achilleas-k @alexxa
data/azure/grub9.6+: update expected grub config
4915532 
Update the expected grub config to match the latest changes.

osbuild/images#1814
RHEL 9: RHEL-95423
RHEL 10: RHEL-95418
@alexxa alexxa force-pushed the rhel/azure/grub/serial-io branch from 5050f57 to 4915532 Compare September 9, 2025 10:01
alexxa
alexxa approved these changes Sep 9, 2025
View reviewed changes
Copy link
Collaborator

@alexxa alexxa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@alexxa alexxa merged commit 6b7a7ab into main Sep 9, 2025
1 check passed
@achilleas-k achilleas-k deleted the rhel/azure/grub/serial-io branch September 9, 2025 10:02
achilleas-k added a commit to achilleas-k/osbuild-composer that referenced this pull request Sep 11, 2025
@achilleas-k
test: run older CIV tag on nightlies
6796793 
CIV was recently updated [1] to cover changes in the upstream image
definitions [2].  The 'rhel-azure-grub-serial-io' tag does not include
those changes.  The nightly tests for 9.7 and 10.1 should run with the
older image definitions that do not include the changes

[1] osbuild/cloud-image-val#457
[2] osbuild/images#1814
@achilleas-k achilleas-k mentioned this pull request Sep 11, 2025
Merged
achilleas-k added a commit to achilleas-k/osbuild-composer that referenced this pull request Sep 11, 2025
@achilleas-k
test: run older CIV tag on nightlies
fb3198d 
CIV was recently updated [1] to cover changes in the upstream image
definitions [2] in Azure images.  The 'rhel-azure-grub-serial-io' tag
does not include those changes.  Older versions of osbuild-composer are
being tested in nightlies for 9.7 and 10.1, so it should run with the
older image definitions that do not include the changes.

[1] osbuild/cloud-image-val#457
[2] osbuild/images#1814
achilleas-k added a commit to achilleas-k/osbuild-composer that referenced this pull request Sep 11, 2025
@achilleas-k
test: run older CIV tag on nightlies
2f489bc 
CIV was recently updated [1] to cover changes in the upstream image
definitions [2] in Azure images.  The 'pr-456' tag is the latest that
does not include those changes.  Older versions of osbuild-composer are
being tested in nightlies for 9.7 and 10.1, so it should run with the
older image definitions that do not include the changes.

[1] osbuild/cloud-image-val#457
[2] osbuild/images#1814
achilleas-k added a commit to osbuild/osbuild-composer that referenced this pull request Sep 11, 2025
@achilleas-k
test: run older CIV tag on nightlies
193c04a 
CIV was recently updated [1] to cover changes in the upstream image
definitions [2] in Azure images.  The 'pr-456' tag is the latest that
does not include those changes.  Older versions of osbuild-composer are
being tested in nightlies for 9.7 and 10.1, so it should run with the
older image definitions that do not include the changes.

[1] osbuild/cloud-image-val#457
[2] osbuild/images#1814
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sourcery-ai sourcery-ai[bot] sourcery-ai[bot] left review comments

@alexxa alexxa alexxa approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@achilleas-k @alexxa